Atom Smasher was mostly a hero during his career. He turned villain only during the Black Reign period.
He was created as a hero, Nuklon, in Infinity Inc., and then changed moniker to "Atom Smasher" in Geoff Johns' JSA. He's been 90% of the time a superhero, the dark period was while he was following Black Adam.