Superman’s costume does not make sense with out the trunks. His costume is based of a strongman’s costume and strongmen traditionally wore trunks like Superman. They, like the colourful costume, are worn to make superman less threatening to make him seem fun to the people he saves to stop them being scared.